Skip to content

Commit

Permalink
Drop alt attribute of source favicons
Browse files Browse the repository at this point in the history
The favicons in the source list contained the title of the feed in
their alt attribute. This was redundant since the title is already
shown next to the item, resulting in the title being read multiple
times by accessibility technologies. It was also displayed over
the title when the favicon file was missing.

Closes: #975
  • Loading branch information
jtojnar committed Aug 17, 2017
1 parent 50847c7 commit 5ad0a92
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion templates/source.phtml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class="source <?= isset($this->source) === false ? 'source-new' : '' ?> <?= (isset($this->source) && isset($this->source['error']) && strlen($this->source['error'] > 0)) ? 'error' : '' ?>">
<div class="source-icon">
<?php if (isset($this->source) && isset($this->source['icon']) && $this->source['icon'] !== false && $this->source['icon'] != '0') : ?>
<img src="<?= 'favicons/' . $this->source['icon']; ?>" alt="<?= isset($this->source) ? $this->source['title'] : ''; ?>" />
<img src="<?= 'favicons/' . $this->source['icon']; ?>" alt="" />
<?php endif; ?>
</div>

Expand Down

0 comments on commit 5ad0a92

Please sign in to comment.