-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating to DB Version 11 fails (sqlite) #954
Labels
Comments
jtojnar
added a commit
that referenced
this issue
Jun 23, 2017
In 14442c0, `updatetime` field was introduced to the `items` table. Unfortunately, unlike the initialization, the migration did not flag the field `NOT NULL`. This resulted in the pre-existing items to have `updatetime = 0`. When re-creating the table for adding an another field in 83794f4, the `updatetime` was set to `NOT NULL`, based on the previous initialization. That caused an error when migrating those items. This patch fixes the assumption by setting the `NULL` fields. Closes: #954
jtojnar
added a commit
that referenced
this issue
Jun 23, 2017
In 14442c0, `updatetime` field was introduced to the `items` table. Unfortunately, unlike the initialization, the migration did not flag the field `NOT NULL`. Additionally, the `lastseen` column in MySQL database was added as `NULL`able in 83794f4. These inconsistencies can lead to incorrect assumptions and cause bugs like #954. This patch adds the `NOT NULL` constraint for `updatetime and `lastseen` fields, making the database consistent again. SQLite consistency was already rectified in 83794f4 by re-creating the table.
jtojnar
added a commit
that referenced
this issue
Jun 23, 2017
In 14442c0, `updatetime` field was introduced to the `items` table. Unfortunately, unlike the initialization, the migration did not flag the field `NOT NULL`. This resulted in the pre-existing items to have `updatetime = 0`. When re-creating the table for adding an another field in 83794f4, the `updatetime` was set to `NOT NULL`, based on the previous initialization. That caused an error when migrating those items. This patch fixes the assumption by filling the `NULL` fields. Closes: #954
jtojnar
added a commit
that referenced
this issue
Jun 23, 2017
In 14442c0, `updatetime` field was introduced to the `items` table. Unfortunately, unlike the initialization, the migration did not flag the field `NOT NULL`. Additionally, the `lastseen` column in MySQL database was added as `NULL`able in 83794f4. These inconsistencies can lead to incorrect assumptions and cause bugs like #954. This patch adds the `NOT NULL` constraint for `updatetime` and `lastseen` fields, making the database consistent again. SQLite consistency was already rectified in 83794f4 by re-creating the table.
jtojnar
added a commit
that referenced
this issue
Jun 27, 2017
In 14442c0, `updatetime` field was introduced to the `items` table. Unfortunately, unlike the initialization, the migration did not flag the field `NOT NULL`. Additionally, the `lastseen` column in MySQL database was added as `NULL`able in 83794f4. These inconsistencies can lead to incorrect assumptions and cause bugs like #954. This patch adds the `NOT NULL` constraint for `updatetime` and `lastseen` fields, making the database consistent again. SQLite consistency was already rectified in 83794f4 by re-creating the table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey there,
I'm a long time user of selfoss.
Updating to the latest master fails with this error (obviously, I'm using sqlite)
The problem seem to be some very old entries in my db
I personally fixed it, altering the data in the sqlite table. But I'd suggest altering the update routine.
The text was updated successfully, but these errors were encountered: