fix(cheatcodes): disallow using vm.prank after vm.startPrank
#5520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
reviewed
Aug 1, 2023
mds1
reviewed
Aug 1, 2023
Co-authored-by: Matt Solomon <[email protected]>
|
alright, should be good now @mds1 ! |
2 tasks
aathan
pushed a commit
to aathan/foundry
that referenced
this pull request
Aug 2, 2023
…oundry-rs#5520) * chore: disallow using vm.prank after vm.startprank * chore: rename state single call bool * Update evm/src/executor/inspector/cheatcodes/env.rs Co-authored-by: Matt Solomon <[email protected]> --------- Co-authored-by: Matt Solomon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5515 . This problem (
tx.originnot being updated correctly after doingvm.prankafter avm.startPrank) is introduced in part due to #4884 — we now have certain rules to override pranks that weren't explicit enough in the code. You should probably not be able to callvm.prankafter avm.startPrank, asvm.startPrankis "multi-use" and must be stopped, whilevm.prankis "single use", and one should not overlap the other, as you can usevm.startPrankagain after having used the first startPrank. This is made a little confusing as we don't have achangePrankcheatcode, but rather re-usevm.startPrankfor this.We could probably make a case for allowing this, but this feels like a hard-to-explain possible footgun and I'd rather disallow it entirely.
Solution
Disallow calling
vm.prankafter avm.startPrank.