Use response factory #13
Conversation
|
References #12 |
This was already the minimum through the transitive Diactoros dependency.
composer.json
Outdated
| @@ -9,7 +9,7 @@ | |||
| }, | |||
| "require": { | |||
| "filp/whoops": "^1.1 || ^2.0", | |||
| "zendframework/zend-diactoros": "^1.1.0 || ^2.0" | |||
| "middlewares/utils": "^3.0" | |||
There was a problem hiding this comment.
This implicitly raises the (already implicit) minimu PHP version to 7.2, which I would like to avoid if possible. What alternatives are there for middlewares/utils?
Could I leave the discovery part completely to clients and simply require injecting a factory to the WhoopsRunner class?
(Please rebase the branch on top of the latest master, the build should start failing.)
There was a problem hiding this comment.
I think the point of the Factory is to be setup and global for a project. I think the utils 3.0 is required because of the mocks tbh so maybe by switching to diactoros in require-dev might offer the utils ^2.0 || ^3.0 version range.
There was a problem hiding this comment.
Another option is to explicitly statically set a ResponseFactoryInterface and StreamFactoryInterface from https://github.com/php-fig/http-factory to build a response. The only complete factory interface i know is from middlewares/utils but only from v3 on, which reintroduces that dependency.
There was a problem hiding this comment.
I want to sleep over this one. Thanks for explaining!
|
Reverted tests and switched to Laminas for dev mode since Zend is abandoned. Sorry the commits are a bit messy. |
|
I extracted the relevant commit onto master now - went with PHP 7.2, as other dependencies hardly gave me a choice here. 😕 Thanks so much! This has been released as 2.0. |
Replaced explicit Zend Diactoros requirement with response factory. Updated tests to use mocks instead of any impl.