-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI tests fail on Ubuntu Focal #493
Comments
While we don't know what's the exact source of the error, given that this only happens in Ubuntu Focal, which still uses Qt5, is probably an indication that there is an issue with shared state between Qt 5, PySide6 and pytest-qt. Also, given that it reproducibly happens in a specific line in the code, it could be that we unwillingly trigger a segfault in that Qt 5 version that has been fixed. In any case, end users will actually use Dangerzone with PySide2 and pytest-qt will not be involved. To the best of our knowledge, this combination does not trigger any segfaults. For this reason, and in order to avoid future wild goose chases, we should run each GUI test in a separate process. Turns out that this is not very easy though, due to a PySide issue. To circumvent this, we can change our Makefile to list all the GUI tests and run each one sequentially in a separate Finally, note that we will use this workaround for all the platforms that we support, even if there are no errors for most of them. For now, this makes sense since we will avoid debugging pytest-qt -related issues for all platforms. We can revisit this decision later on. |
This is mainly to check if the CI makes it work properly, especially on Ubuntu Focal, as described in #493
This is mainly to check if the CI makes it work properly, especially on Ubuntu Focal, as described in #493
This is mainly to check if the CI makes it work properly, especially on Ubuntu Focal, as described in #493
This is mainly to check if the CI makes it work properly, especially on Ubuntu Focal, as described in #493
This is mainly to check if the CI makes it work properly, especially on Ubuntu Focal, as described in #493
This is mainly to check if the CI makes it work properly, especially on Ubuntu Focal, as described in #493
This is mainly to check if the CI makes it work properly, especially on Ubuntu Focal, as described in #493
This is mainly to check if the CI makes it work properly, especially on Ubuntu Focal, as described in #493
GUI tests have started to fail on Ubuntu Focal, once we added an unrelated test in our test suite. And by unrelated, we mean that creating even a dummy
tests/isolation_provider/test_base.py
test that returns immediately makes them error out with:With this small change, and only in our CI runners, CI tests fail reproducibly in Ubuntu Focal environments, and on a specific line. Also, attempting to SSH into our CI runners and run these tests manually does not trigger any error, even in our containerized Dangerzone environments.
So, we don't know the root cause of this error, and we haven't achieved reproducing it in an interactive session, so that we can probe deeper.
The text was updated successfully, but these errors were encountered: