Add automember module

[jake2184]

I've extended & updated an automember module, first proposed in #392. That PR looked active for a couple of weeks, but silent for months. I've forked it, rebased on master, and addressed a few of the issues highlighted in the PR.

I can't tag the previous author, Mark Hahl / @wolskie. I haven't changed any of the author notes or copyright.

[jake2184]

oh, the tag did work! Just didn't autocomplete.

[rjeffman]

Hello @jake2184,

The task failing is due to differences in string handling in Python 2 and 3. To fix this issue you should add the following to the imports:

from ansible.module_utils._text import to_text

And then, when you need the string, you use to_text(data)

Thank you for you contribution!

[jake2184]

I seem to be getting errors now that I'm fairly sure are unrelated to any of my changes:

> {"ansible_facts": {"discovered_interpreter_python": "/usr/libexec/platform-python"}, "changed": false, "msg": "Kerberos authentication failed: kinit: Cannot read password while getting initial credentials\n"

This is during facts collection? Is there anything I need to setup (rebase on master?) or change to get these working?

[rjeffman]

That is really weird... I'll look into that in the next days, as I really don't have the time now.

[rjeffman]

@jake2184 the failures on the checks, currently, have nothing to do with your changes as we are having some issues with the images used for testing. I'm fixing those, but we can't use the checks for a while. I'll let you know when everything is working again.

[rjeffman]

@chr15p, all test environments are up and running again. Please, fix the failing tests.

[jake2184]

Tests running cleanly

[rjeffman]

@jake2184 great job!

I'll try to do a proper review during this week.

[jake2184]

Can I bump this please @rjeffman ?

[jake2184]

And again @rjeffman @t-woerner

[rjeffman]

@jake2184 I was on vacation, and only returning "tomorrow".

I'll look at it Really Soon Now (tm). :-)

[jake2184]

No worries, as long as it doesn't fall through the cracks :)

[jake2184]

Is this going to be looked at any time soon? @rjeffman

[rjeffman]

Hello, sorry for the too long delay.

We're having issues with CI (and available time), as soon as CI is fixed, we'll restart pushing PRs, automount and automember modules are a priority.

I hope this to be soon, but can't promise as, right now, time is at a premium.

[rjeffman]

Hello @jake2184,

We had issues with CI, and the fixes require that all pending PR are rebased.

Can you please rebase your PR?

[rjeffman]

Tested on the CLI (not the module) and it should work with Centos 7. Just restarted the test.

All FreeIPA version are different in the tested environments. CentOS 7 has FreeIPA version 4.6.8, CentOS 8 is 4.8.7 and Fedora is 4.9.3.

[rjeffman]

After re-running the tests, the same test still fails. Fixing it will require some debuging.

[rjeffman]

I could reproduce your issue locally, with CentOS-7, but have no time to debug it.

If you have podman installed, use this script to test in a container and debug (usually, I debug with ansible_module.warn("VAR: %s" % var)).

[rjeffman]

For some reason, it looks like key and automemberinclusiveregex are swaped. I didn't look any further.

TASK [Add testhostgroup hostgroup automember rule member condition] ************************************
[WARNING]: testhostgroup automember_add_condition: {'automemberinclusiveregex': u'fqdn', 'type':
u'hostgroup', 'key': u'.*.domain.com'}
fatal: [dev-test-master]: FAILED! => {"changed": false, "failed_when_result": true, "msg": "automember_add_condition: testhostgroup: .*.domain.com is not a valid attribute."}

[rjeffman]

@jake2184, sorry, but you'll need to rebase this PR.

For plugins/module_utils/ansible_freeipa_module.py just use what's on the master branch.

[jake2184]

Rebased, comments resolved, awaiting CI checks

[rjeffman]

LGTM.

Forgot that new modules must have a single commit.

[rjeffman]

@jake2184, code for automember is good.

Please, merge all the commits into a single one, and use a commit message base on the one found on PR #357.

[t-woerner]

LGTM

[mhahl]

@jake2184 thank you for taking over the work on this module, I appreciate it very much.