Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoped CSS not working with HTML templates #336

Closed
Tarmil opened this issue Nov 20, 2023 · 2 comments
Closed

Scoped CSS not working with HTML templates #336

Tarmil opened this issue Nov 20, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Tarmil
Copy link
Member

Tarmil commented Nov 20, 2023

Most likely because Node.Elt does not check CssScope like the computation expressions do.

@Tarmil Tarmil added the bug Something isn't working label Nov 20, 2023
@Tarmil
Copy link
Member Author

Tarmil commented Nov 20, 2023

Oh, looks like this will be incompatible with the fact that the template engine uses plain HTML whenever possible (ie for all subtrees that don't contain any holes). Because with scoped CSS, we need to add an attribute to every element.

I'd hate to have to get rid of this optimization though. Maybe we can add a static parameter to the type provider so the user can choose: if they use scoped CSS, they must disable the optimization, but if they don't use scoped CSS, then they can enable it.

@Tarmil
Copy link
Member Author

Tarmil commented Nov 20, 2023

Fixed in v0.23.52.

@Tarmil Tarmil closed this as completed Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant