Fix symbol types where an incomplete type check occurs #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 9, 2015 16:06
The PR fixed the fragmented types that are currently presented on an incomplete type check i.e. if a referenced nuget package is not restored etc. e.g. types may be represented by `?25354-> ?25345` rather than ’a -> ‘b Ive fixed all the occurrence that I can see happen although there could be further issues in `FSharpMemberOrFunctionOrValue.FullType` as I only touched `ValRef`’s
|
Any comments? |
| @@ -1460,8 +1470,8 @@ and FSharpMemberOrFunctionOrValue(cenv, d:FSharpMemberOrValData, item) = | |||
| let tau = v.TauType | |||
| let argtysl,_ = GetTopTauTypeInFSharpForm cenv.g curriedArgInfos tau range0 | |||
| let argtysl = if v.IsInstanceMember then argtysl.Tail else argtysl | |||
|
|
|||
| [ for argtys in argtysl do | |||
| let prettyArgtysl = argtysl |> List.map (fun a -> PrettyTypes.PrettifyTypesN1 cenv.g (a, tau)) | |||
There was a problem hiding this comment.
You should prettify tau, not the pieces one by one.
There was a problem hiding this comment.
Not sure I understand, PrettyTypes.PrettifyTypes1 tau ?
Would we not have to do GetTopTauTypeInFSharpForm and then disregard the head if its an instance?
|
It looks good. Unit tests? |
|
Unit test will require a discrete fragmented type failure case, the only one I know of is when a nuget package is not restored, Ill try and get a small unit test to cover this. |
rojepp
pushed a commit
to rojepp/FSharp.Compiler.Service
that referenced
this pull request
Oct 13, 2015
|
@7sharp9 This kind of problem should occur whenever necessary referenced DLLs are not available and you have code that uses constructs in those DLLs. |
|
Closed in favour of #442 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixed the fragmented types that are currently presented on an
incomplete type check i.e. if a referenced nuget package is not
restored etc.
e.g. types may be represented by
?25354-> ?25345rather than ’a -> ‘bIve fixed all the occurrence that I can see happen although there could
be further issues in
FSharpMemberOrFunctionOrValue.FullTypeas I onlytouched
ValRef’s