Skip to content
This repository has been archived by the owner on Oct 31, 2021. It is now read-only.

Update to FCS 1.4.2.0 #1178

Merged
merged 3 commits into from
Oct 17, 2015
Merged

Update to FCS 1.4.2.0 #1178

merged 3 commits into from
Oct 17, 2015

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Oct 16, 2015

No description provided.

@dsyme
Copy link
Contributor Author

dsyme commented Oct 16, 2015

This exposed a bug in the newly released FCS 1.4.1: fsharp/fsharp-compiler-docs#447

@vasily-kirichenko
Copy link
Contributor

Updated to 1.4.2. Waiting for CI.

@dsyme
Copy link
Contributor Author

dsyme commented Oct 16, 2015

I have been using the Visual F# Power Tools from the CI build of this PR for two hours now (on the large FSharp.Compiler.Service project).

It feels like things have really improved - memory is still largish (as expected) but I got a lot of work done staying in the 1.3GB-1.6GB range. The UI was very responsive the whole time and all the VFPT features felt smoother. I even started to turn VFPT features back on and was able to run with unused namespace gray-out for the second session.

It honestly feels like my machine Is back alive again - I can now work on my large F# solutions with Visual F# Power Tools enabled and get all the productivity benefits that come from that.

I'd say this is ready to go in. If people want to try this on their own large solutions, here it is: https://ci.appveyor.com/project/dungpa/visualfsharppowertools/build/2.2.0-a1510161958/artifacts

@dsyme dsyme changed the title Update to FCS 1.4.1 (please trial before merging) Update to FCS 1.4.2.0 Oct 16, 2015
vasily-kirichenko added a commit that referenced this pull request Oct 17, 2015
@vasily-kirichenko vasily-kirichenko merged commit f7cb319 into master Oct 17, 2015
@vasily-kirichenko
Copy link
Contributor

@dsyme Fantastic! I cannot believe you fixed the memory issue.

@vasily-kirichenko
Copy link
Contributor

@dsyme I tried to set keepAssemblyContents = false and it behaved even better. Is it worth to set this flag or there are some hidden cost behind it? I turn the flag on in this PR #1179

@dsyme
Copy link
Contributor Author

dsyme commented Oct 17, 2015

That should default to false: https://github.com/fsharp/FSharp.Compiler.Service/blob/03e3d0260fdd670999b338b8f2cd8df8b1411899/src/fsharp/vs/service.fs#L3048

You need to set this if you want the typed expression tree (AssemblyContents) - and yes, it will use more memory.

@dungpa dungpa deleted the dsyme-patch-1 branch October 22, 2015 09:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants