launchNodePSOCK() will not produce an error instead of a warning if i…

…t detect that the system() call had a non-zero exit value
futureverse · Dec 13, 2024 · 76e3f56 · 76e3f56
1 parent 85eab24
commit 76e3f56
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,5 +1,5 @@
 Package: parallelly
-Version: 1.40.1-9002
+Version: 1.40.1-9003
 Title: Enhancing the 'parallel' Package
 Imports:
     parallel,

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,11 @@
 # Version (development version)
 
+## New Features
+
+ * `makeClusterPSOCK()` will now produce an error, rather than a
+   warning, when the local system command used to launch the parallel
+   worker failed with a non-zero exit code.
+
 ## Bug Fixes
 
  * `makeClusterPSOCK()` on MS Windows failed to launch remote workers,

diff --git a/R/launchNodePSOCK.R b/R/launchNodePSOCK.R
@@ -63,7 +63,7 @@ launchNodePSOCK <- function(options, verbose = FALSE) {
       mdebugf("%s- Exit code of system() call: %s", verbose_prefix, res)
     }
     if (res != 0) {
-      warnf("system(%s) had a non-zero exit code: %d", local_cmd, res)
+      stopf("Failed to launch PSOCK node. Reason: system(%s) had a non-zero exit code (%d)", local_cmd, res)
     }
   }