-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support prerelease with ModuleFast and make PSResourceGet the default method #453
Support prerelease with ModuleFast and make PSResourceGet the default method #453
Conversation
This need to be documented in the README.md. But gonna wait a while to see what more changes happen around resolving dependencies. |
3bc5326
to
a61e59d
Compare
Todo:
|
9f84426
to
0f35500
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 7 unresolved discussions
CHANGELOG.md
line 17 at r1 (raw file):
modules when using `Get-Module -ListAvailable`. The templates already has this configuration. - Update PSResourceGet to default to v1.0.1 if no version is passes in parameter
Typo
README.md
line 93 at r1 (raw file):
It is possible to use [PSResourceGet](https://github.com/PowerShell/PSResourceGet) to resolve dependencies. PSResourceGet works with WIndows PowerShell and
Typo
README.md
line 150 at r1 (raw file):
'ComputerManagementDsc' = ':[9.1.0-preview0002]' # Must be greater than 9.1.0-preview0002
higher version
README.md
line 153 at r1 (raw file):
'ComputerManagementDsc' = '>9.1.0-preview0002' # Must be less than 9.1.0-preview0002
lower version
README.md
line 162 at r1 (raw file):
'ComputerManagementDsc' = '>=9.1.0-preview0002' # Must be greater than 9.1.0-preview0002
Duplicate example
Resolve-Dependency.ps1
line 738 at r1 (raw file):
$modulesToSave = @( 'PSDepend' # Always include PSDepend for backward compatibility.
Extra white space
Resolve-Dependency.ps1
line 876 at r1 (raw file):
{ $modulesToSave += @{ Name = $requiredModule.Name
Extra white space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @johlju)
I'm merging this. Tested generating and building a SimpleModule with this change. Let me know if there are any issues and I will fix them as soon as possible. |
/az run |
Pull Request
Pull Request (PR) description
Fixed
that is part of RequiredModules.psd1. This only works when setting the
parameter value
ModuleFastBleedingEdge
to$true
in the configurationfile Resolve-Dependencies.psd1. When
ModuleFastBleedingEdge
is enabledit is also possible to specify NuGet version ranges
in RequiredModules.psd1, although then the file is not compatible with
PSResourceGet or PSDepend (so no fallback can happen).
or specific version is configured.
of resolving dependencies. It is possible to change to the method
PowerShellGet & PSDepend by changing the configuration.
Closes #450
Fixes #445
Task list
build.ps1 -ResolveDependency
).This change is