-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if event is cancelable before calling preventDefault #357
Conversation
Just discovered this doesn't completely clean up the console. But I think it's a step in the right direction. |
Can we have this merged? |
This solves the issue for me. |
Adding However a new wild one appears sometimes : So yes, check if event is cancellable in OnPanMove would be great 👍 |
+1. Could really use this fix. |
I'm not sure how to resolve this. Since these are built files, should I just choose my version? Super difficult to read the diff. |
Any update on this issue? |
Any news on this issue? |
? |
@mac9416 Could you please clean up code changes? I hope it gets merged soon. |
Updated PR: #437 |
This uses MDN's recommendation to avoid preventDefault when it shouldn't be used:
https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelable
Sorry for the messy diff. I think Docker made the whitespace changes? Let me know if you'd like me to clean it up and submit another PR.