Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas test failures #91

Closed
jamesjer opened this issue Feb 23, 2023 · 4 comments
Closed

Canvas test failures #91

jamesjer opened this issue Feb 23, 2023 · 4 comments

Comments

@jamesjer
Copy link
Contributor

The tests in the 2.0.0 release fail in canvas.tst, because the string returned by FrancyId(canvas) does not match the expected value. The same is true for the id field in the output of PrintObj(canvas). If I am reading the code correctly, the ID is a random uuid prepended with F. This means that test is very nearly guaranteed to fail.

@jamesjer
Copy link
Contributor Author

This also affects the output of GetLinks(graph); in graph.tst.

@mcmartins
Copy link
Member

That's true, the ID are uuids. The weird thing is that locally and on the github actions the tests were passing, e.g.: https://github.com/gap-packages/francy/actions/runs/4237207803/jobs/7363113640

I've added gap> RANDOM_SEED(1); on all tests in the develop branch (which I believe should do the trick).

@jamesjer
Copy link
Contributor Author

That's interesting. I see that if I run the tests multiple times, I get the same ID in each run. But if I completely remove the buildroot and spin up a new one, I get a different ID, which also persists across multiple tests. Does that mean that the random number generator is given a predictable seed? If so, then RANDOM_SEED(1) should indeed do the trick.

mcmartins added a commit that referenced this issue Feb 23, 2023
fixed workflows
fixed dockerfile for binder
mcmartins added a commit that referenced this issue Feb 27, 2023
* Canvas test failures #91
fixed workflows
fixed dockerfile for binder

* Fix unknown entity warnings (#90)

* fixed package info

* fix for #92 #93 and #94
added new workflow for releasetools

* use yarn instead of npm

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

---------

Co-authored-by: Manuel Martins <[email protected]>
Co-authored-by: Jerry James <[email protected]>
mcmartins added a commit that referenced this issue Mar 2, 2023
* Canvas test failures #91
fixed workflows
fixed dockerfile for binder

* Fix unknown entity warnings (#90)

* fixed workflows
fixed dockerfile for binder

* fixed dockerfile for binder

* fixed dockerfile for binder

* fixed dockerfile for binder

* fixed package info

* fix for #92 #93 and #94
added new workflow for releasetools

* revert changes from latest jupyterlab extension cookiecutter

* use yarn instead of npm

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

* new release 2.0.2 to test ReleaseTools

---------

Co-authored-by: Manuel Martins <[email protected]>
Co-authored-by: Jerry James <[email protected]>
mcmartins added a commit that referenced this issue Mar 10, 2023
* Canvas test failures #91
fixed workflows
fixed dockerfile for binder

* Fix unknown entity warnings (#90)

* fixed workflows
fixed dockerfile for binder

* fixed dockerfile for binder

* fixed dockerfile for binder

* fixed dockerfile for binder

* fixed package info

* fix for #92 #93 and #94
added new workflow for releasetools

* revert changes from latest jupyterlab extension cookiecutter

* use yarn instead of npm

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

* new release 2.0.2 to test ReleaseTools

* Update RELEASE.yml

use already present gh-pages branch

---------

Co-authored-by: Manuel Martins <[email protected]>
Co-authored-by: Jerry James <[email protected]>
mcmartins added a commit that referenced this issue Mar 10, 2023
* Canvas test failures #91
fixed workflows
fixed dockerfile for binder

* Fix unknown entity warnings (#90)

* fixed workflows
fixed dockerfile for binder

* fixed dockerfile for binder

* fixed dockerfile for binder

* fixed dockerfile for binder

* fixed package info

* fix for #92 #93 and #94
added new workflow for releasetools

* revert changes from latest jupyterlab extension cookiecutter

* use yarn instead of npm

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

* new release 2.0.2 to test ReleaseTools

* Update RELEASE.yml

use already present gh-pages branch

* Update RELEASE.yml

---------

Co-authored-by: Manuel Martins <[email protected]>
Co-authored-by: Jerry James <[email protected]>
mcmartins added a commit that referenced this issue Mar 14, 2023
* Canvas test failures #91
fixed workflows
fixed dockerfile for binder

* Fix unknown entity warnings (#90)

* fixed workflows
fixed dockerfile for binder

* fixed dockerfile for binder

* fixed dockerfile for binder

* fixed dockerfile for binder

* fixed package info

* fix for #92 #93 and #94
added new workflow for releasetools

* revert changes from latest jupyterlab extension cookiecutter

* use yarn instead of npm

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

* workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)

* new release 2.0.2 to test ReleaseTools

* Update RELEASE.yml

use already present gh-pages branch

* Update RELEASE.yml

* added fetch-depth: 0 to fetch all branches

---------

Co-authored-by: Manuel Martins <[email protected]>
Co-authored-by: Jerry James <[email protected]>
mcmartins added a commit that referenced this issue Mar 14, 2023
* develop:
  update gh-pages branch
  added fetch-depth: 0 to fetch all branches
  Update RELEASE.yml
  Update RELEASE.yml
  new release 2.0.2 to test ReleaseTools
  workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)
  workaround for yarn caches on subprojects: from actions/setup-node#488 (comment)
  use yarn instead of npm
  revert changes from latest jupyterlab extension cookiecutter
  fix for #92 #93 and #94 added new workflow for releasetools
  fixed package info
  fixed dockerfile for binder
  fixed dockerfile for binder
  fixed dockerfile for binder
  fixed workflows fixed dockerfile for binder
  Fix unknown entity warnings (#90)
  Canvas test failures #91 fixed workflows fixed dockerfile for binder
@mcmartins
Copy link
Member

Yes, that should do the trick if the tests are ran on the same "session".
Though, for the system packages release tests run twice which then fails, see comment on #92
I've removed the offending test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants