-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wait for onsyschange #9
Conversation
… has been manually saved
… Preview is clicked
❌ Deploy Preview for content-sync failed. 🔨 Explore the source changes: 230c464 🔍 Inspect the deploy log: https://app.netlify.com/sites/content-sync/deploys/615de5e4671c270008474455 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few really tiny things
Co-authored-by: Matt Ehlinger <[email protected]>
This PR solves (with bandaids) the contentful onSysChange vs data save timing issue.
The initial 3 second wait is required to make sure the incremental build doesn't happen before Contentful saves the entry data (this happens suprisingly often). The rest is a pile of bandaids because Contentful doesn't expose an API to let us know when the data is saved.
Manually saving the data on our own causes other problems:
TODO: