address PR feedback

gatsbyjs · Apr 9, 2020 · dba8edc · dba8edc
1 parent cae80d5
commit dba8edc
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/...src/redux/reducers/__tests__/redirects.js → ...src/redux/reducers/__tests__/redirects.ts b/...src/redux/reducers/__tests__/redirects.js → ...src/redux/reducers/__tests__/redirects.ts
@@ -1,9 +1,11 @@
+import { ICreateRedirectAction, IRedirect } from "../../types"
+
 let reducer
 
 describe(`redirects`, () => {
   beforeEach(() => {
     jest.isolateModules(() => {
-      reducer = require(`../redirects`).default
+      reducer = require(`../redirects`).redirectsReducer
     })
   })
   it(`lets you redirect to an internal url`, () => {
@@ -73,7 +75,10 @@ describe(`redirects`, () => {
   })
 
   it(`prevents duplicate redirects`, () => {
-    function createRedirect(fromPath, toPath) {
+    function createRedirect(
+      fromPath: string,
+      toPath: string
+    ): ICreateRedirectAction {
       return {
         type: `CREATE_REDIRECT`,
         payload: { fromPath, toPath },
@@ -92,7 +97,7 @@ describe(`redirects`, () => {
   })
 
   it(`allows multiple redirects with same "fromPath" but different options`, () => {
-    function createRedirect(redirect) {
+    function createRedirect(redirect: IRedirect): ICreateRedirectAction {
       return {
         type: `CREATE_REDIRECT`,
         payload: redirect,

diff --git a/packages/gatsby/src/redux/reducers/index.js b/packages/gatsby/src/redux/reducers/index.js
@@ -1,5 +1,6 @@
 const reduxNodes = require(`./nodes`)
 const lokiNodes = require(`../../db/loki/nodes`).reducer
+import { redirectsReducer } from "./redirects"
 
 const backend = process.env.GATSBY_DB_NODES || `redux`
 
@@ -59,7 +60,7 @@ module.exports = {
   jobsV2: require(`./jobsv2`),
   webpack: require(`./webpack`),
   webpackCompilationHash: require(`./webpack-compilation-hash`),
-  redirects: require(`./redirects`).default,
+  redirects: redirectsReducer,
   babelrc: require(`./babelrc`),
   schemaCustomization: require(`./schema-customization`),
   themes: require(`./themes`),

diff --git a/packages/gatsby/src/redux/reducers/redirects.ts b/packages/gatsby/src/redux/reducers/redirects.ts
@@ -1,5 +1,4 @@
 import _ from "lodash"
-
 import { IGatsbyState, IRedirect, ICreateRedirectAction } from "../types"
 
 const redirects = new Map<string, IRedirect[]>()
@@ -23,7 +22,7 @@ function add(redirect: IRedirect): void {
   samePathRedirects.push(redirect)
 }
 
-const redirectsReducer = (
+export const redirectsReducer = (
   state: IGatsbyState["redirects"] = [],
   action: ICreateRedirectAction
 ): IGatsbyState["redirects"] => {
@@ -45,5 +44,3 @@ const redirectsReducer = (
       return state
   }
 }
-
-export default redirectsReducer