-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gatsby-plugin-mdx: MDXRender accepts components - but no functionality #21682
Comments
Thanks for opening this issue! We should remove the We won't need to make it a breaking change to remove the prop because it was never being passed on properly in the first place. |
@johno @gatsbyjs/learning This will also need some documentation work. |
Hi guys, so are we removing the component property from documentation? |
I took it up as the issue was getting rather quiet. Quick question: Would it also be preferred to directly convert to typescript? |
* Remove 'components' from MDXRenderer signature Work for #21682 * Removed 'components' from MDXRenderer type * removed components * removed unneeded extra imports
…yjs#24271) * Remove 'components' from MDXRenderer signature Work for gatsbyjs#21682 * Removed 'components' from MDXRenderer type * removed components * removed unneeded extra imports
Description
https://www.gatsbyjs.org/packages/gatsby-plugin-mdx/#mdxprovider
accepts components to allow modification
MDXRerender also accepts components but it does not do anything with them.
Steps to reproduce
This neither changes the a tag to MdxLink nor throws an error.
This should not be the case at least in typescript
Expected result
What should happen?
Either remove the components property or add the the functionality of MDXProvider to MDXRenderer.
Environment
System:
OS: Linux 5.3 Ubuntu 18.04.4 LTS (Bionic Beaver)
CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Shell: 4.4.20 - /bin/bash
Binaries:
Node: 10.19.0 - /usr/bin/node
Yarn: 1.21.1 - ~/.yarn/bin/yarn
npm: 6.13.4 - /usr/bin/npm
Languages:
Python: 3.7.3 - /home/user/anaconda3/bin/python
Browsers:
Chrome: 80.0.3987.106
Firefox: 73.0
npmPackages:
gatsby: ^2.15.24 => 2.15.24
gatsby-plugin-layout: ^1.1.22 => 1.1.22
gatsby-plugin-mdx: ^1.0.73 => 1.0.73
gatsby-plugin-react-helmet: ^3.1.8 => 3.1.8
gatsby-plugin-typescript: ^2.1.9 => 2.1.9
gatsby-source-filesystem: ^2.1.46 => 2.1.46
gatsby-transformer-json: ^2.2.26 => 2.2.26
npmGlobalPackages:
gatsby-cli: 2.8.27
The text was updated successfully, but these errors were encountered: