fix(gatsby-plugin-mdx): fix filter by heading depth #16344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes an issue where heading fields on an MDX node can't be filtered by depth. Here's the query that I was using:
In this case, all headings would be returned, regardless of their depth. This was happening because in the
headings
resolver, thedepth
arg was defined as aHeadingMdx
here, but filtering would only happen ifdepth
is a number.I changed the logic to only perform filtering when
depth
is one of the values thatHeadingMdx
allows, and adjusted the filtering to make this strategy work properly.