Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] use peer deps for styled components #2832

Merged
merged 1 commit into from
Nov 7, 2017

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Nov 7, 2017

No description provided.

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit fcb00b3

https://deploy-preview-2832--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit fcb00b3

https://deploy-preview-2832--using-drupal.netlify.com

@KyleAMathews
Copy link
Contributor

Maybe just do this in v2? Is this causing a lot of trouble right now that we need a breaking change?

@jquense
Copy link
Contributor Author

jquense commented Nov 7, 2017

I was thinking since they are versioned independently it wasn't a big deal to do a v2 of this plugin yeah? We can put it whereever, it was making it consistent with the emotion plugin and addresses some of the concerns in #2446

@KyleAMathews
Copy link
Contributor

Ah right, yeah do a v2 release. Cool — will do 👍

I've also been thinking on all the v2s we're doing for plugins that when we bump Gatsby to v2, we can bump all plugins to v2 as well except ones we've already bumped to v2. Most plugins except webpack ones shouldn't have a breaking change for Gatsby v2 but moving everything to v2 will reduce confusion I think.

@KyleAMathews KyleAMathews merged commit 14f5f07 into master Nov 7, 2017
@jquense jquense deleted the style-components branch November 7, 2017 18:52
singuerinc added a commit to singuerinc/gatsby that referenced this pull request Nov 7, 2017
* upstream/master: (156 commits)
  Publish new version
  Publish
  use peer reps (gatsbyjs#2832)
  escape pipe in markdown (gatsbyjs#2835)
  Publish
  Small, perhaps nitpicky, change but not explicitly stating which file this config was referencing tripped up the flow for me for a bit when running through step-by-step. (gatsbyjs#2834)
  Fix no trailing slashes (gatsbyjs#2828)
  Publish
  Update to the latest Prettier
  Small fixes to tutorial part one (gatsbyjs#2821)
  Revert "Fix: only the first feed was getting options.query injected. Now all the feeds have it injected. (gatsbyjs#2571)" (gatsbyjs#2820)
  Revert "Added the ability to customize the feed's title (gatsbyjs#2573)" (gatsbyjs#2822)
  keep track of root node id with weakmap instead of storing root node id as additional field in sub nodes (gatsbyjs#2812)
  Publish
  Add onLoad prop to gatsby-image (gatsbyjs#2818)
  Add post "Migrate from Hugo to Gatsby" (gatsbyjs#2808)
  Update readme showcase so that source links are distinct (gatsbyjs#2815)
  Publish
  Add Softin Sistemas' website into Showcase (gatsbyjs#2793)
  Validate that gatsby-source-filesystem paths exist fixes gatsbyjs#2806 (gatsbyjs#2813)
  ...
@monsieurnebo
Copy link
Contributor

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants