Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): only load the necessary logger #33463

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Oct 7, 2021

Description

Small memory improvement by only loading the necessary logger instead of all of them.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 7, 2021
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also improves startup time for the cli

@wardpeet wardpeet added topic: cli Related to the Gatsby CLI type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 11, 2021
@wardpeet wardpeet marked this pull request as ready for review October 11, 2021 12:24
@wardpeet wardpeet merged commit 934035d into master Oct 11, 2021
@wardpeet wardpeet deleted the chore/logger-lazy branch October 11, 2021 13:52
vladar pushed a commit that referenced this pull request Oct 13, 2021
vladar pushed a commit that referenced this pull request Oct 14, 2021
(cherry picked from commit 934035d)

Co-authored-by: Ward Peeters <[email protected]>
wardpeet added a commit to herecydev/gatsby that referenced this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cli Related to the Gatsby CLI type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants