Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate nightlies from main branches #334

Merged
merged 4 commits into from
Nov 17, 2020
Merged

Conversation

chapulina
Copy link
Contributor

Solves #319

Unblocks PRs tied to #331 which require nightlies for GitHub actions CI.

@chapulina chapulina requested a review from j-rivero as a code owner October 29, 2020 17:30
@chapulina
Copy link
Contributor Author

Generated new nightly scheduler jobs using this branch:

https://build.osrfoundation.org/job/_dsl_ignition_collection/281/

Note how the nightly scheduler has all libraries populated now:

https://build.osrfoundation.org/job/ignition-edifice-nightly-scheduler/build?delay=0sec

Ran nightly scheduler using this branch and a few releases failed, looking into it:

https://build.osrfoundation.org/job/ignition-edifice-nightly-scheduler/37/console

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

I think the failures were because the debbuild jobs didn't exist. 5c67c3f should address that.

Generated debbuild jobs using this branch:

https://build.osrfoundation.org/job/_dsl_ignition/1059/

Retriggered nightly scheduler:

https://build.osrfoundation.org/job/ignition-edifice-nightly-scheduler/38/console

It's not there yet. Looking into it.

@chapulina
Copy link
Contributor Author

Some libraries were missing -release repos. I created those, except for ign-cmake3 and ign-tools2 because new_ignition_release_repos.bash doesn't work well for them: #310 (comment).

Some release repos has a master branch instead of main, and the nightly release didn't like that. See #335 for future release repos. I manually fixed the ones that had already been created a while back.

Finally, the last issue is related to how ign-transport10 has 2 digits in the version number. I haven't looked into what needs updating for that.

Here's the latest run:

https://build.osrfoundation.org/job/ignition-edifice-nightly-scheduler/40/console

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from j-rivero November 3, 2020 23:01
@scpeters
Copy link
Contributor

scpeters commented Nov 4, 2020

Finally, the last issue is related to how ign-transport10 has 2 digits in the version number. I haven't looked into what needs updating for that.

I think I know what's causing this

@scpeters
Copy link
Contributor

scpeters commented Nov 4, 2020

Finally, the last issue is related to how ign-transport10 has 2 digits in the version number. I haven't looked into what needs updating for that.

I think I know what's causing this

I think it's this logic here:

https://github.com/ignition-tooling/release-tools/blob/f720f98cc467132b47207e22ba1bd2fc313bdecb/jenkins-scripts/dsl/ignition_collection.dsl#L593-L597

@j-rivero j-rivero self-requested a review November 5, 2020 18:35
@j-rivero
Copy link
Contributor

j-rivero commented Nov 5, 2020

I think it's this logic here:

right. I've patched it in 5ff00ab. Testing run here: https://build.osrfoundation.org/job/ignition-edifice-nightly-scheduler/51/console . Fails for transport10-release (no main branch) and sdformat11-release (no repo).

@j-rivero j-rivero merged commit 1d1b6df into master Nov 17, 2020
@j-rivero j-rivero deleted the chapulina/nightly_main branch November 17, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants