Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentative fix for FindOptiX.cmake #472

Draft
wants to merge 1 commit into
base: gz-cmake4
Choose a base branch
from

Conversation

roncapat
Copy link

@roncapat roncapat commented Feb 11, 2025

Lost some hours to fix gz_rendering build warnings about missing dependency OptiX only to find out in gazebosim/gz-rendering#1010 that basically that renderer is ancient/broken... nevertheless, I think it would be good to leave here the bit and bolts that I discovered to be issue in my setup for OptiX discovery.

First of all, on Ubuntu 22.04 the library name is libnvoptix.so.1 while this script currently searches for liboptix.so or liboptix.1.so, so the lookup would always fail IMHO.

Secondly, but it can be my fault, I tried setting:

  • --cmake-args OPTIX_INSTALL_DIR=path
  • --cmake-args OptiX_INSTALL_DIR=path
  • export OPTIX_INSTALL_DIR=path

but the include files were never detected. I solved the hard way by directly checking the $env var in find_path call.

Signed-off-by: Patrick Roncagliolo <[email protected]>
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Feb 11, 2025
@j-rivero
Copy link
Contributor

Thanks for the PR ! Are you interested into having the support in place even the rendering code can be broken with current versions?

Looking into the code:

set(OptiX_INSTALL_DIR "$ENV{OPTIX_INSTALL_DIR}" CACHE PATH "Path to OptiX installed location.")

Should be getting th OPTIX_INSTALL_DIR enviroment variable and put that in the correct place. In the worst case, I'm fine if we change all the ocurrences from OptiX_INSTALL_DIR to $ENV{OPTIX_INSTALL_DIR} but please be sure to delete the CMakeCache.txt and run the thing to check if the existing code is really working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

2 participants