Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 to 6 20211018 #192

Merged
merged 4 commits into from
Oct 18, 2021
Merged

5 to 6 20211018 #192

merged 4 commits into from
Oct 18, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Oct 18, 2021

➡️ Forward port

Port ign-msgs5 to ign-msgs6

Branch comparison: ign-msgs6...ign-msgs5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 4 commits August 9, 2021 10:35
Signed-off-by: Louise Poubel <[email protected]>
* Fix trivial typo in command line help message

Signed-off-by: Nate Koenig <[email protected]>

* Remove comment

Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from caguero as a code owner October 18, 2021 18:39
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #192 (67b82ac) into ign-msgs6 (e559c9e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-msgs6     #192   +/-   ##
==========================================
  Coverage      84.59%   84.59%           
==========================================
  Files              7        7           
  Lines            818      818           
==========================================
  Hits             692      692           
  Misses           126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e559c9e...67b82ac. Read the comment docs.

@chapulina
Copy link
Contributor

The Windows CI is failing because of a new warning introduced by ign-tools: gazebosim/gz-tools#63 (comment)

@chapulina chapulina merged commit 48d8e3e into ign-msgs6 Oct 18, 2021
@chapulina chapulina deleted the 5-to-6-20211018 branch October 18, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants