Return nullptr when message fails to populate #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-msgs10 #384 +/- ##
==========================================
Coverage 97.26% 97.26%
==========================================
Files 27 27
Lines 1169 1170 +1
==========================================
+ Hits 1137 1138 +1
Misses 32 32
|
Signed-off-by: Michael Carroll <[email protected]>
I ended up also adding a test here to prevent regressions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a message with user-provided string data, in the event that the string data isn't well formed, we should be returning a
nullptrrather than an empty message. This indicates to the caller that we failed to create the full message.