-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve message generation tutorial and example #386
Conversation
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-msgs10 #386 +/- ##
==========================================
Coverage 97.26% 97.26%
==========================================
Files 27 27
Lines 1170 1170
==========================================
Hits 1138 1138
Misses 32 32 |
Signed-off-by: Addisu Z. Taddese <[email protected]>
I've added the new file to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This expands the example, and adds some more documentation about how message generation works in a tutorial.
While there is some duplication between them, I think there is value in having the tutorial, as those are what gets indexed in the documentation as well as coverage in the tutorial party. I think there is value in having the example as that gets CI coverage.