Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ES2016+ and webpack. #10

Closed
wants to merge 15 commits into from
Closed

Use ES2016+ and webpack. #10

wants to merge 15 commits into from

Conversation

graingert
Copy link

@graingert graingert commented Nov 29, 2016

This also removes the use of inline JS <script> tags and the eval() function.

@graingert
Copy link
Author

sadly the version of gzip2 is very out of date. It's recommended to use compressjs instead: jvrousseau/bzip2.js#2
https://github.com/skeggse/node-bzip
https://github.com/cscott/compressjs

@graingert
Copy link
Author

@n1474335 do you have any views on this approach?

@graingert
Copy link
Author

graingert commented Nov 30, 2016

@n1474335 this is now completed for a modern project under webpack.

to get a production build, run "npm run build", to get a dev/watcher build use "npm start" to lint run "npm run eslint"

@graingert graingert changed the title Start modernizing project Use ES2016+ and webpack. Nov 30, 2016
@graingert
Copy link
Author

@n1474335 can you review this before there's too many conflicts

@n1474335
Copy link
Member

Hey @graingert,

I'm impressed by your commitment! There are a lot of fairly major changes all in this one request and we're not in a position to merge them all at this time. We'll need to look at how this would fit in with our internal setup. I'm not against using some form of library management, but we need to consider which system is best suited.

I'm going to close this pull request as there are too many disparate concepts, but we will definitely take forward some of your ideas. Thank you for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants