Accessibility - Favourites dialog box keyboard navigation #1737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue #1718
This PR aims to solve some of the 'limited keyboard interaction' outlined in section 4/5 of keyboard Navigation in the issue linked above, focusing on the Edit favourites dialog box. E.g. Inability to focus on menu items and view tooltips through tabbing, use of arrow keys for navigation and Lack of keyboard alternative for drag-and-drop operations
Code changes:
User-facing changes:
To replicate:
Tab
to first operationArrow Right
on any operation and eitherArrow Left
to focus back on the operation orEnter
/Space
to delete from listCtrl
+Up Arrow
/Down Arrow
should move the focused operation up or down the list (should loop back to top/bottom)Tab
to exit the list of operations and either reset/save/or cancel