Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete selection not being recognized in CC box of "Add annoton" #488

Closed
krchristie opened this issue Aug 31, 2017 · 5 comments
Closed

Comments

@krchristie
Copy link

The cellular_component box in the "Add annoton" is not working properly. When I type something into the box, I get appropriate autocomplete options based on what I type, and I can select something and the corresponding ID shows up in the box, just like for the gene product, MF, and BP boxes. However, when I click the "Add" button, I get a pop up that says "Must select something from autocomplete list for cellular_component".

I first noticed this a few days ago, but it was the end of the day and I didn't have time to confirm that it was the interface versus a user error or to submit a ticket, but it is still happening today and is specific for that box. There is no problem with any of the other three boxes in the "Add annoton" section. The "Add individual" section also works properly, even for adding CC terms.

@kltm kltm added this to the hotfix milestone Aug 31, 2017
@kltm kltm changed the title CC autocomplete not being recognized in CC box of "Add annoton" Autocomplete selection not being recognized in CC box of "Add annoton" Aug 31, 2017
@kltm
Copy link
Member

kltm commented Aug 31, 2017

Duplicated. Ugh, likely a reversion from #473 (from #471) ... checking now.

@cmungall
Copy link
Member

cmungall commented Aug 31, 2017

I believe the error message should actually be "Must select something from autocomplete list for molecular function". It is forcing you to add an MF, even if root. I think it should make a root MF instance for you if the field is blank, but that aside I think this is just a reporting error.

EDIT my diagnosis is incorrect, ignore

kltm added a commit that referenced this issue Aug 31, 2017
@krchristie
Copy link
Author

It doesn't matter whether there is something in the MF box or not. If there is anything in the CC box, I get this error, either with the MF box blank or filled.

kltm added a commit that referenced this issue Aug 31, 2017
@kltm
Copy link
Member

kltm commented Aug 31, 2017

I believe that fix should now be public. Do a hard refresh of your page and the fix should be picked up in the client.

@kltm kltm closed this as completed Aug 31, 2017
@krchristie
Copy link
Author

Yes, fixed now 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants