Upgrade to ImageSharp 3 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bump SixLabors.ImageSharp to 3.1.2 - SixLabors.ImageSharp.Drawing to 2.1.0 - adjust Bounds and Size function calls to use properties instead
|
Thanks, and sorry for the delay! |
|
An updated version is now available on NuGet: https://www.nuget.org/packages/FaceAiSharp/0.5.23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on the integration of ImageSharp 3.
Brief summarization of the contents of this pull request:
I've run the tests located in the FaceAiSharp.Tests project to assure this does not introduce breaking behaviors.
This might introduce breaking changes in consumers that do use SixLabors.ImageSharp 2, but vice versa this fixes a runtime error when the consumer uses SixLabors.ImageSharp 3. The SixLabors.ImageSharp.ImageInfoExtensions were removed from the library which then causes as TypeLoaderException.