Skip to content

Commit

Permalink
Merge PR #336 (Add drydep to benchmark summary & drydep plots to 1mon…
Browse files Browse the repository at this point in the history
… bmks)

This merge brings PR # (Add the DryDep collection to the benchmark summary
table, and DryDepVel plots to 1-mon cloud benchmarks, by @yantosca) into
the GCPy development stream.

The GEOS-Chem `DryDep` collection was restored to all fullchem benchmark
simulations in geoschem/geos-chem#2144.  This is
the corresponding GCPy PR, which includes code to:
1. Add the `DryDep` collection to the benchmark summary table
2. Plot dry deposition velocities in 1-hr cloud benchmarks

Signed-off-by: Bob Yantosca <[email protected]>
  • Loading branch information
yantosca committed Aug 29, 2024
2 parents a33bebf + b20d99e commit 9e66715
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,14 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
### Added
- Example script `gcpy/examples/hemco/make_hemco_sa_spec.py` (creates the HEMCO standalone configuration file `HEMCO_sa_Spec.rc`)
- Module `benchmark_gcclassic_stats.py` for scraping statistics from GEOS-Chem Classic cloud benchmarks
- Dry deposition velocity comparison plots in 1-month cloud benchmarks

### Changed
- Changed format of `% diff` column from `12.3e` to `12.3f` in benchmark timing tables
- Updated `gcpy/benchmark/modules/emission_species.yml` file with emission species for GEOS-Chem 14.5.0
- Updated `gcpy/benchmark/modules/benchmark_categories.yml` with the latest categories for GEOS-Chem 14.5.0
- Updated `gcpy/benchmark/modules/lumped_species.yml` with speciations for GEOS-Chem 14.5.0
- Add `DryDep` to list of collections included in benchmark summary table

### Fixed
- Fixed formatting error in `.github/workflows/stale.yml` that caused the Mark Stale Issues action not to run
Expand Down
2 changes: 1 addition & 1 deletion gcpy/benchmark/cloud/template.1mo_benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ options:
emis_table: True
plot_jvalues: True
plot_aod: True
plot_drydep: False #Hotfix (bmy, 06 Feb 2024)
plot_drydep: True
mass_table: True
mass_accum_table: False
ops_budget_table: False
Expand Down
4 changes: 3 additions & 1 deletion gcpy/benchmark/run_benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ def run_benchmark_default(config):
collections = [
'AerosolMass',
'Aerosols',
#'DryDep',
'DryDep',
'Emissions',
'JValues',
'Metrics',
Expand Down Expand Up @@ -1100,6 +1100,7 @@ def run_benchmark_default(config):
collections=[
'AerosolMass',
'Aerosols',
'DryDep',
'Emissions',
'JValues',
'Metrics',
Expand Down Expand Up @@ -1607,6 +1608,7 @@ def run_benchmark_default(config):
collections=[
'AerosolMass',
'Aerosols',
'DryDep',
'Emissions',
'JValues',
'Metrics',
Expand Down

0 comments on commit 9e66715

Please sign in to comment.