Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes in transport tracer benchmark code #224

Merged
merged 3 commits into from
May 31, 2023
Merged

Bug fixes in transport tracer benchmark code #224

merged 3 commits into from
May 31, 2023

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented May 31, 2023

This PR includes two fixes for the transport tracer 1-year benchmark:

  1. Fix print commands for last four lines of mass conservation table. Previously the lines were written to the terminal rather than the output file.
  2. Remove references to mass accumulation table in the transport tracer benchmark python file. Those came in by mistake and the mass accumulation table should only be in the 1-month benchmark files.

lizziel added 2 commits May 31, 2023 12:54
@lizziel
Fix bug where end of mass conservation table was written to screen no…
9e27d2f 
…t file

Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel
Fix bug where mass accum table partially implemented for transport tr…
cf104fc 
…acers

Mass accumulation table should only be impelemented for full chemistry
1-month benchmarks.

Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel lizziel added the category: Bug Something isn't working label May 31, 2023
@lizziel lizziel requested a review from yantosca May 31, 2023 17:52
@lizziel lizziel self-assigned this May 31, 2023
@lizziel lizziel changed the base branch from main to dev May 31, 2023 17:53
yantosca
yantosca requested changes May 31, 2023
View reviewed changes
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updates are simple bug fixes. We just need to update the CHANGELOG.md and then we are good to merge.

@lizziel
Update changelog
52a35a1 
Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel
Copy link
Contributor Author

lizziel commented May 31, 2023

Should be all set now. I didn't include the mass accumulation table fix in the changelog since it came in with a recent commit.

yantosca
yantosca approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changelog update @lizziel. Good to merge.

@yantosca yantosca added this to the 1.4.0 milestone May 31, 2023
@yantosca yantosca merged commit 04a7aa9 into dev May 31, 2023
@yantosca yantosca deleted the bugfix/transport_tracers_benchmark branch May 31, 2023 18:38
@yantosca yantosca added category: Bug Fix Fixes a bug that was previously reported topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output and removed category: Bug Something isn't working labels Aug 1, 2023
hannahnesser pushed a commit to hannahnesser/gcpy that referenced this pull request Jan 22, 2024
@yantosca
Merge PR geoschem#224 (bug fixes in transport tracer benchmark code)
09bf0f6 
This merge brings PR geoschem#224 by @lizziel into the GCPy 1.4.0 development
stream.  It fixes an issue where some lines of text in the transport
tracer mass conservation table were sent to stdout instead of to a file.
It also removes the call to print the mass accumulation table from
the 1-year transport tracer benchmark (it should only be in the 1-month
output.

Signed-off-by: Bob Yantosca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yantosca yantosca yantosca approved these changes

Assignees

@lizziel lizziel

Labels
category: Bug Fix Fixes a bug that was previously reported topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lizziel @yantosca