-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS native SDK integration #2625
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- macOS native SDK integration ([#2625](https://github.com/getsentry/sentry-dotnet/pull/2625)) If none of the above apply, you can opt out of this check by adding |
Directory.Build.props
Outdated
@@ -18,12 +18,14 @@ | |||
</PropertyGroup> | |||
|
|||
<!-- NO_MOBILE can be passed in via an environment variable or a build property to disable all mobile targets --> | |||
<PropertyGroup Condition="'$(NO_MOBILE)' == 'true'"> | |||
<PropertyGroup Condition="'$(NO_MOBILE)' == ''"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't want this checked into source control
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need a second sln
after all. Unles we find another way to avoid this.
Can we have a symlink? Sentry.NoMobile.sln
is a symlink to Sentry.sln
? So you can add the checks back on the msbuild files based on sln file name?
I've originally wanted to update this PR and make the fixes but it's not possible to build macos native AOT apps at this time (before .net 8 RC2), so I'm going to fork this further and only do Windows+sentry-native in the first step. |
Although #2767 brings native AOT debug images by using sentry-native for macOS (because it's much easier then getting cocoa working and bundled properly), I'll leave this open for the overall approach taken with all the scope sync, etc. We may revisit this later when there are features only sentry-cocoa can fulfill. |
Replaced by #2770 |
An experiment to introduce specific mac target and bundle the native SDK (cocoa or sentry-native)
TODO:
sentry-cocoa
for desktop and remove the bundled dylibdebug-files upload
sentry-cli#1746First successful crash captured natively: https://sentry-sdks.sentry.io/issues/4483237642/?project=5428537&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=90d&stream_index=0