-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replay): Capture exception when internal_sdk_error
client report happens
#13072
Merged
billyvg
merged 3 commits into
develop
from
feat-replay-capture-exception-internal-sdk-error
Jul 30, 2024
Merged
feat(replay): Capture exception when internal_sdk_error
client report happens
#13072
billyvg
merged 3 commits into
develop
from
feat-replay-capture-exception-internal-sdk-error
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
c298lee
approved these changes
Jul 26, 2024
mydea
reviewed
Jul 29, 2024
@@ -83,6 +83,8 @@ async function _addEvent( | |||
DEBUG_BUILD && logger.error(error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's replace this line instead with the handleException
call, I'd say? Otherwise this would double-log as of now (and it probably also makes sense to log/capture this before the await, I think?)
…rt happens We currently have no visibility when this client report happens. Lets capture the exception if our experimental flag is on. Also refactors `_handleException()` to be a public method instead of private.
ba7ee16
to
370194f
Compare
mydea
approved these changes
Jul 30, 2024
This was referenced Aug 27, 2024
This was referenced Aug 28, 2024
This was referenced Aug 29, 2024
This was referenced Aug 30, 2024
This was referenced Aug 30, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have no visibility when this client report happens. Lets capture the exception if our experimental flag is on.
Also refactors
_handleException()
to be a public method instead of private.