feat(nestjs): Automatic instrumentation of nestjs interceptors before route execution #13153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
chargome
reviewed
Aug 1, 2024
|
|
||
| const transactionEvent = await pageloadTransactionEventPromise; | ||
|
|
||
| console.log(transactionEvent.spans); |
There was a problem hiding this comment.
Suggested change
| console.log(transactionEvent.spans); |
chargome
reviewed
Aug 1, 2024
|
|
||
| const transactionEvent = await pageloadTransactionEventPromise; | ||
|
|
||
| console.log(transactionEvent.spans); |
There was a problem hiding this comment.
Suggested change
| console.log(transactionEvent.spans); |
chargome
reviewed
Aug 1, 2024
| @@ -32,6 +32,8 @@ import type { Observable } from 'rxjs'; | |||
| * Interceptor to add Sentry tracing capabilities to Nest.js applications. | |||
| */ | |||
| class SentryTracingInterceptor implements NestInterceptor { | |||
| public static readonly __SENTRY_INTERNAL__ = true; | |||
There was a problem hiding this comment.
l: maybe add a comment for this one
nicohrubec
changed the title
This was referenced Aug 27, 2024
This was referenced Aug 28, 2024
This was referenced Aug 30, 2024
This was referenced Aug 30, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds automatic instrumentation of interceptors to
@sentry/nestjs. Interceptors in nest have a@Injectabledecorator and implement ainterceptfunction. So we can simply extend the existing instrumentation to add a proxy forintercept.Current screenshot from my sample app:
Remark: Interceptors allow users to add functionality before and after a route handler is called. This PR adds tracing to whatever happens before the route is executed. I am still figuring out how to trace any instructions after the route was executed. Will do that in a separate PR.