feat(nuxt): Set transaction name for server error #13292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
reviewed
Aug 9, 2024
| @@ -14,9 +14,17 @@ export default defineNitroPlugin(nitroApp => { | |||
| } | |||
| } | |||
|
|
|||
| const currentScope = Sentry.getCurrentScope(); | |||
There was a problem hiding this comment.
l: Is there a particular reason you're creating a binding for the current scope here instead of just calling getCurrentScope().setTransactionName() directly?
Comment on lines
19
to
23
| const { method, path } = { | ||
| method: errorContext.event && errorContext.event._method ? errorContext.event._method : '', | ||
| path: errorContext.event && errorContext.event._path ? errorContext.event._path : 'unknown-path', | ||
| }; | ||
| currentScope.setTransactionName(`${method} ${path}`); |
There was a problem hiding this comment.
m: I recommend not setting the transaction name at all if the path is unknown, because we will give other sensible default mechanisms to activate and show in the product, ie. root span name, or stack trace.
Lms24
approved these changes
Aug 12, 2024
| @@ -1,4 +1,4 @@ | |||
| import { captureException } from '@sentry/node'; | |||
| import * as Sentry from '@sentry/node'; | |||
There was a problem hiding this comment.
super-l/hint: It's totally fine to make a namespace (import * as) or named imports. No need to change it back, just fyi :)
This was referenced Sep 4, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the transaction name to display the API route where the error happened:
