feat(nextjs): export SentryBuildOptions #13296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
reviewed
Aug 9, 2024
packages/nextjs/src/index.types.ts
Outdated
| @@ -40,6 +40,8 @@ export declare const metrics: typeof clientSdk.metrics & typeof serverSdk.metric | |||
|
|
|||
| export { withSentryConfig } from './config'; | |||
|
|
|||
| export type { SentryBuildOptions } from './config/types'; | |||
There was a problem hiding this comment.
Let's do
export type { SentryBuildOptions } from './types'
inside config/index.ts instead.
index.types.ts already exports everything from config/index.ts.
andreiborza
reviewed
Aug 9, 2024
andreiborza
approved these changes
Aug 9, 2024
andreiborza
added a commit
that referenced
this pull request
Aug 9, 2024
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #13296 --------- Co-authored-by: andreiborza <[email protected]> Co-authored-by: Andrei Borza <[email protected]>
This was referenced Sep 4, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #13295
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).I run the linting, it said that there are 16 errors but none are in the file I changed.