feat(sveltekit): Always add browserTracingIntegration #13322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
changed the title
s1gr1d
requested review from
Lms24,
a team and
nicohrubec
and removed request for
a team
Lms24
approved these changes
Aug 12, 2024
packages/sveltekit/src/client/sdk.ts
Outdated
Comment on lines
48
to
50
| } else { | ||
| return getDefaultSvelteIntegrations(options); | ||
| } |
There was a problem hiding this comment.
l: we don't need to throw the last return statement into an else block but we can just return directly. Not a problem but it shaves off a couple of bytes and reduces blocks :)
size-limit report 📦
|
Lms24
approved these changes
Aug 13, 2024
This was referenced Sep 4, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13011
ref: #13318