Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Add lru-memoizer instrumentation #13796

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

onurtemizkan
Copy link
Collaborator

Resolves: #13309

Adds integration for lru-memoizer using @opentelemetry/instrumentation-lru-memoizer.

This instrumentation does not create any spans. It only assigns the span context into memoized callbacks used in lru-memoizer's load.

Ported a test case from the original implementation and tested manually to validate.

@onurtemizkan onurtemizkan changed the title feat(node): Add instrumentation feat(node): Add lru-memoizer instrumentation Sep 25, 2024
@onurtemizkan onurtemizkan force-pushed the onur/lrumemoizer-integration branch from 76b0be2 to 751b463 Compare September 25, 2024 13:21
@onurtemizkan onurtemizkan force-pushed the onur/lrumemoizer-integration branch from 751b463 to 8b2f86c Compare September 25, 2024 13:21
@onurtemizkan onurtemizkan force-pushed the onur/lrumemoizer-integration branch from 4b7358f to cceeb8a Compare September 25, 2024 13:59
Copy link
Contributor

github-actions bot commented Sep 25, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.63 KB - -
@sentry/browser - with treeshaking flags 21.42 KB - -
@sentry/browser (incl. Tracing) 34.86 KB - -
@sentry/browser (incl. Tracing, Replay) 71.36 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.79 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 75.71 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 88.48 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.36 KB - -
@sentry/browser (incl. metrics) 26.91 KB - -
@sentry/browser (incl. Feedback) 39.77 KB - -
@sentry/browser (incl. sendFeedback) 27.29 KB - -
@sentry/browser (incl. FeedbackAsync) 32.08 KB - -
@sentry/react 25.38 KB - -
@sentry/react (incl. Tracing) 37.84 KB - -
@sentry/vue 26.8 KB - -
@sentry/vue (incl. Tracing) 36.75 KB - -
@sentry/svelte 22.76 KB - -
CDN Bundle 23.94 KB - -
CDN Bundle (incl. Tracing) 36.63 KB - -
CDN Bundle (incl. Tracing, Replay) 71.13 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.44 KB - -
CDN Bundle - uncompressed 70.14 KB - -
CDN Bundle (incl. Tracing) - uncompressed 108.6 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.48 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 233.69 KB - -
@sentry/nextjs (client) 37.8 KB - -
@sentry/sveltekit (client) 35.43 KB - -
@sentry/node 125.13 KB +0.17% +215 B 🔺
@sentry/node - without tracing 93.57 KB - -
@sentry/aws-serverless 103.28 KB - -

View base workflow run

@AbhiPrasad AbhiPrasad merged commit 2343380 into develop Sep 26, 2024
132 checks passed
@AbhiPrasad AbhiPrasad deleted the onur/lrumemoizer-integration branch September 26, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lruMemoizerIntegration for Node
2 participants