Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replay): Try/catch sendBufferedReplayOrFlush to prevent cycles #13900

Merged

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Oct 7, 2024

It is possible that an error gets thrown outside
of flushing (we should be catching exceptions in
flush and do no re-throw), which our core SDK
error handler would catch due to global rejection
handler and trigger replay SDK to flush again.

It is possible that an error gets thrown outside
of flushing (we should be catching exceptions in
flush and do no re-throw), which our core SDK
error handler would catch due to global rejection
handler and trigger replay SDK to flush again.
Copy link
Contributor

github-actions bot commented Oct 7, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.73 KB - -
@sentry/browser - with treeshaking flags 21.53 KB - -
@sentry/browser (incl. Tracing) 34.97 KB - -
@sentry/browser (incl. Tracing, Replay) 71.5 KB +0.01% +7 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.92 KB +0.01% +4 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 75.83 KB +0.01% +5 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 88.6 KB +0.01% +6 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.47 KB +0.01% +6 B 🔺
@sentry/browser (incl. metrics) 27 KB - -
@sentry/browser (incl. Feedback) 39.87 KB - -
@sentry/browser (incl. sendFeedback) 27.38 KB - -
@sentry/browser (incl. FeedbackAsync) 32.17 KB - -
@sentry/react 25.49 KB - -
@sentry/react (incl. Tracing) 37.94 KB - -
@sentry/vue 26.9 KB - -
@sentry/vue (incl. Tracing) 36.86 KB - -
@sentry/svelte 22.87 KB - -
CDN Bundle 24.05 KB - -
CDN Bundle (incl. Tracing) 36.76 KB - -
CDN Bundle (incl. Tracing, Replay) 71.25 KB +0.01% +1 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 76.57 KB +0.01% +2 B 🔺
CDN Bundle - uncompressed 70.53 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.04 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 221.06 KB +0.03% +46 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 234.27 KB +0.02% +46 B 🔺
@sentry/nextjs (client) 37.91 KB - -
@sentry/sveltekit (client) 35.56 KB - -
@sentry/node 124.5 KB - -
@sentry/node - without tracing 93.64 KB - -
@sentry/aws-serverless 103.3 KB - -

View base workflow run

@billyvg billyvg marked this pull request as ready for review October 7, 2024 22:47
@billyvg billyvg requested a review from a team as a code owner October 7, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants