fix(replay): Ignore older performance entries when starting manually #13969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
c298lee
approved these changes
Oct 15, 2024
billyvg
reviewed
Oct 15, 2024
Comment on lines
1061
to
1062
| // We leave 1s wiggle room to accomodate timing differences for "immedidate" manual starts | ||
| const initialTimestampInSeconds = this._context.initialTimestamp / 1000 - 1; |
There was a problem hiding this comment.
Do we want the wiggle room? Since it's manual start, I think it's ok to only capture events after start. It's easier to explain to users as well.
There was a problem hiding this comment.
the problem is that if you have code like this, I guess:
Sentry.init({
replaysErrorSampleRate: 0,
replaysSessionSampleRate: 0,
integrations: [replay]
});
if (isImportantUser) {
replay.start();
}Like this kind of pattern, where users start manually but "immediately", we would otherwise probably miss many of the page load performance entries, as they are often correctly pre-dated to Date.now() 🤔 but no strong feelings, it is a bit "random". happy to generally remove the wiggle room!
There was a problem hiding this comment.
Ah didn't consider that... I think we keep it simple and remove the wiggle room, but don't feel strongly about this.
billyvg
approved these changes
Oct 17, 2024
billyvg
reviewed
Oct 17, 2024
mydea
force-pushed
the
fn/replay-performance-buffer
branch
from
5ee3f10 to
e861f46
Compare
|
I removed the wiggle room, I left in the test that shows the current behavior for immediate start as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For replay, performance entries are captured separately, and added to the replay before we send it.
Generally, this works just fine, because when we buffer, we clear the captured performance events whenever the buffer is cleared.
However, when we manually start the replay, it can happen that we capture performane entries from way before we started the replay manually, which will in turn extend the timeline of the replay potentially drastically.
To fix this, we now drop any performance events, when starting manually, that happened more than a second before we manually started the replay.
The 1s is an arbitrary number to accomodate the fact that some entries can be emitted slightly before - when we immediately run
replay.start()we generally want to try to keep those too.