fix(replay): Fix onError callback
#14002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the `onError` callback added in #13721 -- the option itself was not being propagated to the replay options.
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
c298lee
reviewed
Oct 24, 2024
| @@ -406,6 +410,8 @@ describe('Integration | sendReplayEvent', () => { | |||
| // Replay has stopped, no session should exist | |||
| expect(replay.session).toBe(undefined); | |||
| expect(replay.isEnabled()).toBe(false); | |||
| expect(onError).toHaveBeenCalledTimes(5); | |||
There was a problem hiding this comment.
It gets called each time replay fails to send until it hits max
c298lee
approved these changes
Oct 24, 2024
billyvg
deleted the
fix-replay-fix-onError-not-propagating-through-options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
onErrorcallback added in #13721 -- the option itself was not being propagated to the replay options.