feat(nuxt): Add piniaIntegration
#14138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
force-pushed
the
sig/pinia-nuxt
branch
from
6c631ca to
7ace30b
Compare
s1gr1d
force-pushed
the
sig/pinia-nuxt
branch
from
7ace30b to
3cd9bcc
Compare
s1gr1d
changed the title
piniaIntegration
6 tasks
andreiborza
reviewed
Oct 31, 2024
CHANGELOG.md
Outdated
| @@ -10,6 +10,73 @@ | |||
|
|
|||
| - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott | |||
|
|
|||
| - **feat(nuxt): Add Sentry Pinia plugin ([#14138](https://github.com/getsentry/sentry-javascript/pull/14138))** | |||
There was a problem hiding this comment.
m: the PR description here doesn't match the actual PR
| consoleSandbox(() => { | ||
| // eslint-disable-next-line no-console | ||
| console.warn( | ||
| '[Sentry] You added the Pinia integration, but the passed parameter `pinia` has the wrong value. Make sure to enable Pinia by adding `"@pinia/nuxt"` to your Nuxt modules array and pass pinia to Sentry with `piniaIntegration(usePinia())`. Current value of `pinia`: ', |
There was a problem hiding this comment.
ultra-l: I'd change the prose and remove the you/your
There was a problem hiding this comment.
Passive language: "The pinia integration was configured/added, ..."
| consoleSandbox(() => { | ||
| // eslint-disable-next-line no-console | ||
| console.warn( | ||
| '[Sentry] You added the Pinia integration, but the passed parameter `pinia` has the wrong value. Make sure to enable Pinia by adding `"@pinia/nuxt"` to your Nuxt modules array and pass pinia to Sentry with `piniaIntegration(usePinia())`. Current value of `pinia`: ', |
There was a problem hiding this comment.
l: You don't need the extra space after :, a space is rendered by default between arguments passed to console logs.
chargome
approved these changes
Oct 31, 2024
CHANGELOG.md
Outdated
| Sentry.init({ | ||
| integrations: [ | ||
| Sentry.piniaIntegration(usePinia(), { | ||
| /* optinal Pinia plugin options */ |
There was a problem hiding this comment.
Suggested change
| /* optinal Pinia plugin options */ | |
| /* optional Pinia plugin options */ |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Lms24
approved these changes
Nov 4, 2024
| expect(actionBreadcrumb?.message).toBe('Transformed: addItem'); | ||
| expect(actionBreadcrumb?.level).toBe('info'); | ||
|
|
||
| const stateContext = error.contexts?.state?.state; |
There was a problem hiding this comment.
q (probably no action required): Are the double state keys on purpose?
There was a problem hiding this comment.
Yes, this is on purpose: https://develop.sentry.dev/sdk/data-model/event-payloads/contexts/#state-context
andreiborza
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reverting #14134, this is a more bundle-size friendly way of adding monitoring for Pinia in Nuxt.
The Nuxt SDK now allows you to track Pinia state for captured errors. To enable the Pinia plugin, add the
piniaIntegrationto your client config: