Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nestjs): Handle GraphQL contexts in SentryGlobalFilter #14320

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Nov 15, 2024

Ref: #14292

Goal is to make the SentryGlobalFilter handle all cases, removing the need for SentryGlobalGraphQLFilter and SentryGlobalGenericFilter.

* https://github.com/nestjs/nest/blob/master/packages/core/exceptions/external-exception-filter.ts
*
* The ExternalExceptinFilter is not exported, so we reimplement this filter here.
* Global filter to handle exceptions in NestJS + GraphQL applications and report them to Sentry.
*/
class SentryGlobalGraphQLFilter {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we deprecate this one then?

Copy link
Member Author

@lforst lforst Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First we wanna release it, then at some point deprecate. See #14292

@lforst lforst merged commit 72751da into develop Nov 15, 2024
49 checks passed
@lforst lforst deleted the lforst-make-global-filter-generic branch November 15, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants