Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Deprecate urlEncode #14406

Merged
merged 3 commits into from
Nov 22, 2024
Merged

feat(core): Deprecate urlEncode #14406

merged 3 commits into from
Nov 22, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Nov 21, 2024

Ref #14267

Deprecates and removes internal usages of urlEncode.

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol we don't even use this anymore ourselves? 😅 good riddance then.

Copy link
Contributor

github-actions bot commented Nov 22, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.88 KB - -
@sentry/browser - with treeshaking flags 21.56 KB -0.03% -6 B 🔽
@sentry/browser (incl. Tracing) 35.46 KB +0.01% +1 B 🔺
@sentry/browser (incl. Tracing, Replay) 72.24 KB +0.02% +14 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.53 KB -0.01% -2 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 76.52 KB +0.01% +2 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 89.01 KB -0.02% -11 B 🔽
@sentry/browser (incl. Feedback) 39.62 KB -0.03% -10 B 🔽
@sentry/browser (incl. sendFeedback) 27.51 KB -0.01% -2 B 🔽
@sentry/browser (incl. FeedbackAsync) 32.31 KB -0.02% -5 B 🔽
@sentry/react 25.58 KB - -
@sentry/react (incl. Tracing) 38.32 KB +0.01% +2 B 🔺
@sentry/vue 27.04 KB +0.02% +5 B 🔺
@sentry/vue (incl. Tracing) 37.29 KB +0.05% +18 B 🔺
@sentry/svelte 23.02 KB -0.02% -4 B 🔽
CDN Bundle 24.04 KB - -
CDN Bundle (incl. Tracing) 37.03 KB +0.02% +4 B 🔺
CDN Bundle (incl. Tracing, Replay) 71.82 KB +0.01% +4 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 77.17 KB +0.01% +2 B 🔺
CDN Bundle - uncompressed 70.86 KB -0.06% -40 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 110.21 KB -0.04% -40 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.01 KB -0.02% -40 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 236.23 KB -0.02% -40 B 🔽
@sentry/nextjs (client) 38.42 KB -0.01% -1 B 🔽
@sentry/sveltekit (client) 35.97 KB +0.02% +7 B 🔺
@sentry/node 134.48 KB -0.01% -11 B 🔽
@sentry/node - without tracing 96.3 KB -0.02% -18 B 🔽
@sentry/aws-serverless 106.57 KB -0.01% -4 B 🔽

View base workflow run

Copy link

codecov bot commented Nov 22, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
658 1 657 25
View the top 1 failed tests by shortest run time
integrations/ContextLines/noAddedLines/test.ts should not add source context lines to errors from script files
Stack Traces | 30s run time
test.ts:6:11 should not add source context lines to errors from script files

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@lforst lforst merged commit 7a10218 into develop Nov 22, 2024
151 of 152 checks passed
@lforst lforst deleted the lforst-urlencode branch November 22, 2024 10:49
AbhiPrasad added a commit that referenced this pull request Dec 18, 2024
ref: #14268

Deprecation PR:
#14406

Removes `urlEncode`. This has no replacement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants