Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Filter out unactionable CEFSharp promise rejection error by default #14595

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 5, 2024

We have internal user reports about an uncaught promise rejection being thrown by a .NET library called CEFSharp. This lib can embed chromium in a .NET app, which I guess means, a web page can be displayed within a .NET app. Apparently there's some problem that spams this error to some of our users.

This error seems to happen quite frequently and it's not the first time we're hearing about it:

This was also already reported in the CEFSharp repo

IMHO we can just filter this error by default, so this PR adds the error to be ignored by our default inboundFiltersIntegration (which I still think has a completely misleading name by the way 😅)

@Lms24 Lms24 self-assigned this Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.27 KB +0.32% +75 B 🔺
@sentry/browser - with treeshaking flags 21.94 KB +0.33% +73 B 🔺
@sentry/browser (incl. Tracing) 35.75 KB +0.2% +73 B 🔺
@sentry/browser (incl. Tracing, Replay) 72.98 KB +0.1% +73 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.38 KB +0.13% +78 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 77.29 KB +0.1% +76 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 89.78 KB +0.08% +69 B 🔺
@sentry/browser (incl. Feedback) 40.02 KB +0.18% +73 B 🔺
@sentry/browser (incl. sendFeedback) 27.88 KB +0.26% +73 B 🔺
@sentry/browser (incl. FeedbackAsync) 32.67 KB +0.22% +73 B 🔺
@sentry/react 25.94 KB +0.28% +72 B 🔺
@sentry/react (incl. Tracing) 38.58 KB +0.2% +76 B 🔺
@sentry/vue 27.47 KB +0.26% +72 B 🔺
@sentry/vue (incl. Tracing) 37.59 KB +0.2% +74 B 🔺
@sentry/svelte 23.43 KB +0.33% +77 B 🔺
CDN Bundle 24.41 KB +0.24% +58 B 🔺
CDN Bundle (incl. Tracing) 37.4 KB +0.19% +69 B 🔺
CDN Bundle (incl. Tracing, Replay) 72.6 KB +0.1% +68 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 77.96 KB +0.09% +64 B 🔺
CDN Bundle - uncompressed 71.69 KB +0.18% +128 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 110.97 KB +0.12% +128 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 225.04 KB +0.06% +128 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.26 KB +0.06% +128 B 🔺
@sentry/nextjs (client) 38.86 KB +0.2% +76 B 🔺
@sentry/sveltekit (client) 36.26 KB +0.22% +80 B 🔺
@sentry/node 163 KB +0.05% +73 B 🔺
@sentry/node - without tracing 99.88 KB +0.08% +73 B 🔺
@sentry/aws-serverless 127.38 KB +0.06% +77 B 🔺

View base workflow run

@Lms24 Lms24 requested review from lforst and AbhiPrasad December 5, 2024 16:22
@mydea
Copy link
Member

mydea commented Dec 6, 2024

hmm, no strong feelings, but how important/common is this? Just thinking out loud, if it only happens infrequently, we could also just add it to the default inbound filters in relay? 🤔 it just adds some small bundle size, I am not against it but we should weigh this properly!

@Lms24
Copy link
Member Author

Lms24 commented Dec 6, 2024

Yeah I don't like the bundle size increase either. However, after some more googling, it looks like this happens quite frequently. Given that if we don't filter this out client-side, we still add the error to replays, I think we rather should eat the bytes 😬 I updated the PR description with various issues and posts I found.

@Lms24 Lms24 force-pushed the lms/fix-core-filter-cefsharp-error branch from 6669586 to 54b573c Compare December 7, 2024 11:39
@Lms24 Lms24 merged commit 242ed75 into develop Dec 10, 2024
156 checks passed
@Lms24 Lms24 deleted the lms/fix-core-filter-cefsharp-error branch December 10, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants