feat(v8/solidstart): Add withSentry wrapper for SolidStart config
#15135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
commented
Jan 22, 2025
Comment on lines
+9
to
+25
| * | ||
| * @deprecated This plugin will be removed in v9. Instead, use `withSentry` to wrap your SolidStart config. Example: | ||
| * ``` | ||
| * export default defineConfig( | ||
| * withSentry( | ||
| * { | ||
| * // SolidStart config... | ||
| * }, | ||
| * { | ||
| * // Sentry config | ||
| * org: process.env.SENTRY_ORG, | ||
| * project: process.env.SENTRY_PROJECT, | ||
| * authToken: process.env.SENTRY_AUTH_TOKEN, | ||
| * }, | ||
| * ), | ||
| * ); | ||
| * ``` |
There was a problem hiding this comment.
Everything in this PR is just a backport of the PRs merged into the v9 branch.
Those JSDoc lines are new. And I kept the E2E tests solidstart and solidstart-spa as they were before, to still test that the old way of setting up the SDK (with the Vite plugin) works.
mydea
changed the title
withSentry wrapper for SolidStart configwithSentry wrapper for SolidStart config
…erSentry` (#14862) This PR adds a `withSentry` wrapper for SolidStart's config to build and place `instrument.server.ts` alongside the server build output so that it doesn't have to be placed in `/public` anymore to be discoverable. The setup is changed to be aligned with Nuxt. First, the `instrument.server.ts` file is added to the build output (the sentry release injection file needs to be copied as well - this is not ideal at the moment as there **could** be other imports as well, but it's okay for now) Then, there are two options to set up the SDK: 1. Users provide an `--import` CLI flag to their start command like this: ```node --import ./.output/server/instrument.server.mjs .output/server/index.mjs``` 2. Users can add `autoInjectServerSentry: 'top-level-import'` and the Sentry config will be imported at the top of the server entry ```typescript // app.config.ts import { defineConfig } from '@solidjs/start/config'; import { withSentry } from '@sentry/solidstart'; export default defineConfig(withSentry( { /* ... */ }, { autoInjectServerSentry: 'top-level-import' // optional }) ); ``` --- builds on top of the idea in this PR: #13784 --------- Co-authored-by: Andrei Borza <[email protected]>
…import` (#14863)⚠️ THIS PR IS BASED ON #14862 Adds the option to dynamically import the server config file. ```typescript // app.config.ts import { defineConfig } from '@solidjs/start/config'; import { sentrySolidStartVite, withSentry } from '@sentry/solidstart'; export default defineConfig(withSentry( { /* ... */ }, { autoInjectServerSentry: 'experimental_dynamic-import' }) ); ``` --------- Co-authored-by: Andrei Borza <[email protected]> (cherry picked from commit 38ff6eb)
s1gr1d
force-pushed
the
sig/withSentry-v8
branch
from
6d4eda9 to
c611265
Compare
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #14862 and #14863