ref(flags): rename unleash integration param #15343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
reviewed
Feb 7, 2025
packages/browser/src/integrations/featureFlags/unleash/integration.ts
Outdated
Show resolved
Hide resolved
This was referenced Feb 7, 2025
billyvg
approved these changes
Feb 10, 2025
aliu39
added a commit
that referenced
this pull request
Feb 20, 2025
Renaming this parameter to keep the name consistent with #15319. We can reuse this generic name for future FF integrations. The old name is still supported but now marked as deprecated. As a result both params have to be optional, the constructor throws if neither is given. The old name will not be supported in #15343.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming this parameter to keep the name consistent with statsigIntegration. We can reuse this generic name for future FF integrations.
This integration is not in use for v9 so we're directly changing the options type. Plan for v8: we'll define the same options type but with
featureFlagsClientClass(new) andunleashClientClass(old) both optional, annotating the latter with@deprecated.