Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): Only use filename with file extension from command #15445

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Feb 19, 2025

The Nuxt SDK also uses the preview command to determine where to put the Sentry top-level import. Like this: node .output/server/index.mjs (would add Sentry to index.mjs)

However, the function to get the file name also used folder names without file extensions which led to Sentry not being included at the top of the index file.

This was a problem in e.g. Azure as the command is the following: npx @azure/static-web-apps-cli start ./public --api-location ./server

@s1gr1d s1gr1d requested review from Lms24 and andreiborza February 19, 2025 15:18
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nuxt also uses the preview command to determine where to put the Sentry top-level import.

I'm confused, that's us doing it, right?

However, it also used folder names without file extensions which led to Sentry not being included at the top of the index file.

That's also us, right?

Just asking to clarify 😅 the change itself looks reasonable to me!

@s1gr1d
Copy link
Member Author

s1gr1d commented Feb 19, 2025

Yes, I edited the content so it's more clear :D
with "Nuxt" I meant our Nuxt package.

@s1gr1d s1gr1d merged commit adca0f5 into develop Feb 19, 2025
36 checks passed
@s1gr1d s1gr1d deleted the sig/fix-filename-from-command branch February 19, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants