Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add links to span options #15453

Merged
merged 4 commits into from
Feb 24, 2025
Merged

feat(core): Add links to span options #15453

merged 4 commits into from
Feb 24, 2025

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Feb 20, 2025

part of #14991

@s1gr1d s1gr1d mentioned this pull request Feb 20, 2025
7 tasks
@s1gr1d s1gr1d requested review from Lms24 and chargome February 20, 2025 13:33
Copy link
Contributor

github-actions bot commented Feb 20, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.05 KB - -
@sentry/browser - with treeshaking flags 22.84 KB - -
@sentry/browser (incl. Tracing) 36.13 KB +0.03% +8 B 🔺
@sentry/browser (incl. Tracing, Replay) 73.14 KB +0.01% +7 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.59 KB +0.02% +7 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 77.39 KB +0.02% +8 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 90.34 KB +0.01% +7 B 🔺
@sentry/browser (incl. Feedback) 40.2 KB - -
@sentry/browser (incl. sendFeedback) 27.68 KB - -
@sentry/browser (incl. FeedbackAsync) 32.48 KB - -
@sentry/react 24.87 KB - -
@sentry/react (incl. Tracing) 38.01 KB +0.03% +9 B 🔺
@sentry/vue 27.29 KB +0.03% +7 B 🔺
@sentry/vue (incl. Tracing) 37.81 KB +0.02% +6 B 🔺
@sentry/svelte 23.09 KB - -
CDN Bundle 24.25 KB - -
CDN Bundle (incl. Tracing) 36.15 KB +0.02% +6 B 🔺
CDN Bundle (incl. Tracing, Replay) 71 KB +0.01% +7 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 76.17 KB +0.02% +9 B 🔺
CDN Bundle - uncompressed 70.91 KB - -
CDN Bundle (incl. Tracing) - uncompressed 107.29 KB +0.02% +15 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.57 KB +0.01% +15 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 231.13 KB +0.01% +13 B 🔺
@sentry/nextjs (client) 39.16 KB +0.02% +8 B 🔺
@sentry/sveltekit (client) 36.54 KB +0.04% +12 B 🔺
@sentry/node 129.25 KB - -
@sentry/node - without tracing 98.03 KB - -
@sentry/aws-serverless 107.45 KB - -

View base workflow run

Copy link

codecov bot commented Feb 20, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
4652 3 4649 328
View the top 3 failed test(s) by shortest run time
test/integration/test/client/root-loader.test.ts should throw redirect to an external path with no baggage and trace injected.
Stack Traces | 0.118s run time
root-loader.test.ts:177:1 should throw redirect to an external path with no baggage and trace injected.
test/integration/test/client/root-loader.test.ts should return redirect to an external path with no baggage and trace injected.
Stack Traces | 0.307s run time
root-loader.test.ts:165:1 should return redirect to an external path with no baggage and trace injected.
transactions.test.ts Should send a transaction for instrumented server actions
Stack Traces | 8.73s run time
transactions.test.ts:53:5 Should send a transaction for instrumented server actions

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Base automatically changed from sig/addSpan-core to develop February 24, 2025 13:26
# Conflicts:
#	dev-packages/browser-integration-tests/suites/tracing/linking-addLink/test.ts
#	dev-packages/browser-integration-tests/suites/tracing/linking-addLinks/test.ts
#	packages/core/test/lib/tracing/trace.test.ts
@s1gr1d s1gr1d marked this pull request as ready for review February 24, 2025 13:38
@s1gr1d s1gr1d self-assigned this Feb 24, 2025
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@s1gr1d s1gr1d merged commit 14667ee into develop Feb 24, 2025
153 checks passed
@s1gr1d s1gr1d deleted the sig/links-spanOptions branch February 24, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants