Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db/filesdb: Don't attempt creation if we don't have the perms #41

Merged
merged 1 commit into from
Mar 5, 2024
Merged

db/filesdb: Don't attempt creation if we don't have the perms #41

merged 1 commit into from
Mar 5, 2024

Conversation

joebonrichie
Copy link
Contributor

No description provided.

ermo
ermo approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ermo ermo merged commit 7aab983 into python3 Mar 5, 2024
@ermo ermo deleted the filesdbornotdb branch March 5, 2024 09:37
joebonrichie added a commit that referenced this pull request Sep 24, 2024
@joebonrichie
Revert "Merge pull request #41 from getsolus/filesdbornotdb"
3e185eb 
This reverts commit 7aab983, reversing
changes made to 311e855.

If the file didn't exist it would never get written.
ermo added a commit that referenced this pull request Oct 2, 2024
@ermo
Merge pull request #87 from getsolus/revert-41
228c491 
Revert "Merge pull request #41 from getsolus/filesdbornotdb"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermo ermo ermo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joebonrichie @ermo