Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all direct msg_send calls to metal-rs #1972

Open
kvark opened this issue Apr 25, 2018 · 0 comments
Open

Move all direct msg_send calls to metal-rs #1972

kvark opened this issue Apr 25, 2018 · 0 comments
Labels
backend: Metal difficulty: easy type: refactor value: medium

Comments

@kvark
Copy link
Member

kvark commented Apr 25, 2018

This would be cleaner, and allow more contained way of mitigating gfx-rs/metal-rs#35
cc @gfx-rs/metallists
This was referenced Apr 26, 2018
Merged
Merged
bors bot added a commit to gfx-rs/metal-rs that referenced this issue Apr 26, 2018
@bors @grovesNL
Merge #38
83c8e5b 
38: Add functions from gfx r=kvark a=grovesNL

Moved some functions from gfx (for gfx-rs/gfx#1972)

This isn't comprehensive yet – I've just moved the functions that were mostly straightforward. The remaining cases probably need more discussion (i.e. what to do with `ConcreteBlock` and `IOSurface` dependencies).

Co-authored-by: Joshua Groves <[email protected]>
bors bot added a commit that referenced this issue Apr 29, 2018
@bors @grovesNL
Merge #1973
1793223 
1973: mtl: Remove some `msg_send` r=kvark a=grovesNL

Some initial cleanup for #1972

Depends on gfx-rs/metal-rs#38 to be merged/published first

PR checklist:
- [X] `make` succeeds (on *nix)
- [X] `make reftests` succeeds
- [X] tested examples with the following backends: Metal


Co-authored-by: Joshua Groves <[email protected]>
bors bot added a commit that referenced this issue Apr 29, 2018
@bors @grovesNL
Merge #1973
02e5514 
1973: mtl: Remove some `msg_send` r=kvark a=grovesNL

Some initial cleanup for #1972

Depends on gfx-rs/metal-rs#38 to be merged/published first

PR checklist:
- [X] `make` succeeds (on *nix)
- [X] `make reftests` succeeds
- [X] tested examples with the following backends: Metal


Co-authored-by: Joshua Groves <[email protected]>
@kvark kvark mentioned this issue Aug 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend: Metal difficulty: easy type: refactor value: medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kvark